@lunny I've marked the PR WIP for your consideration, although it's already functional.

It turns out that the review service was the wrong place to add the notifications, as they were already being added a few lines below where the comment is created.

What I'd suggest to follow the "services" model is to move most of routers/repo/pull_review.go to services/pull/review.go (which I removed because it was only calling models now). Perhaps that can be done in a future PR to keep this PR simple.

Codecov Report

Merging #8948 into master will increase coverage by 0.01%.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##           master    #8948      +/-   ##
==========================================
+ Coverage   41.23%   41.25%   +0.01%     
==========================================
  Files         547      546       -1     
  Lines       70794    70801       +7     
==========================================
+ Hits        29195    29207      +12     
+ Misses      37880    37870      -10     
- Partials     3719     3724       +5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b97e04...86f906a. Read the comment docs.

Example review mail:

Close in favor of #8954
I can add the template stuff later, since the work is already done. 😁